Skip to content

[MISC] Removed unused function find_all_indices() from tool_parsers/utils.py#35683

Merged
DarkLight1337 merged 2 commits intovllm-project:mainfrom
taneem-ibrahim:remove_find_all_indices
Mar 3, 2026
Merged

[MISC] Removed unused function find_all_indices() from tool_parsers/utils.py#35683
DarkLight1337 merged 2 commits intovllm-project:mainfrom
taneem-ibrahim:remove_find_all_indices

Conversation

@taneem-ibrahim
Copy link
Copy Markdown
Contributor

@taneem-ibrahim taneem-ibrahim commented Mar 1, 2026

Purpose

Removed unused find_all_indices() from tool_parsers/utils.py to reduce irrelevant code. The code is not used anywhere.

Test Plan

N/A

Test Result

N/A

Signed-off-by: Taneem Ibrahim <taneem.ibrahim@gmail.com>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the find_all_indices function from vllm/tool_parsers/utils.py. This change is a code cleanup, as the function appears to be unused within the provided context.

Copy link
Copy Markdown
Member

@yewentao256 yewentao256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the work!

@yewentao256 yewentao256 added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 2, 2026
@DarkLight1337 DarkLight1337 merged commit 3a6cbf1 into vllm-project:main Mar 3, 2026
48 of 49 checks passed
Copilot AI pushed a commit to machov/vllm that referenced this pull request Mar 10, 2026
…tils.py (vllm-project#35683)

Signed-off-by: Taneem Ibrahim <taneem.ibrahim@gmail.com>
avinashsingh77 pushed a commit to avinashsingh77/vllm that referenced this pull request Mar 12, 2026
…tils.py (vllm-project#35683)

Signed-off-by: Taneem Ibrahim <taneem.ibrahim@gmail.com>
wendyliu235 pushed a commit to wendyliu235/vllm-public that referenced this pull request Mar 18, 2026
…tils.py (vllm-project#35683)

Signed-off-by: Taneem Ibrahim <taneem.ibrahim@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants